Skip to content

Comments

Small fixes: npm migration, root check, config asset extraction, non-interactive mode, system packages fix#7

Merged
trisdoan merged 7 commits intomainfrom
small_fixes
Feb 25, 2026
Merged

Small fixes: npm migration, root check, config asset extraction, non-interactive mode, system packages fix#7
trisdoan merged 7 commits intomainfrom
small_fixes

Conversation

@nilshamerlinck
Copy link
Contributor

@nilshamerlinck nilshamerlinck commented Feb 24, 2026 •
edited
Loading

Summary

  • Replace all `pnpm` references with `npm` (code, tests, docs)
  • Add root user check to `bootstrap.sh` — exits early with a clear error if run as root
  • Remove `uv` installer from example `tools.script` config in README and docs (uv is installed via `bootstrap.sh`)
  • Extract inline config example from `show_config_instructions()` into `trobz_local/assets/odoo_dev.toml`, loaded at runtime via `importlib.resources`
  • Add `-y`/`--yes` flag to skip all confirmations (non-interactive/CI mode)
  • Fix `install-tools` not installing default OS system packages (`UBUNTU_PACKAGES` etc.) when `system_packages` was empty or absent in config; add `--no-install-default-system-packages` flag to opt out

Test plan

  • All 57 existing tests pass (`make test`)
  • Running `bootstrap.sh` as root prints an error and exits
  • `tlc install-tools` on a machine without config still shows the example from the asset file
  • `tlc install-tools -y` runs without any confirmation prompts
  • `tlc install-tools` installs default system packages (e.g. `libldap2-dev`) even when `system_packages` is empty in config
  • `tlc install-tools --no-install-default-system-packages` skips default OS packages

🤖 Generated with Claude Code

nilshamerlinck and others added 7 commits February 24, 2026 12:32
@nilshamerlinck @claude
chore: replace pnpm references with npm
6f2d1db 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@nilshamerlinck @claude
fix: prevent bootstrap.sh from running as root
491f7d2 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@nilshamerlinck @claude
docs: remove uv script entry from README example config
2f4648c 
uv is installed via bootstrap.sh, not via tools.script

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@nilshamerlinck @claude
docs: remove uv script entry from project-overview-pdr example config
1af9e5f 
uv is installed via bootstrap.sh, not via tools.script

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@nilshamerlinck @claude
refactor: extract config example to assets/odoo_dev.toml
86dbd18 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@nilshamerlinck @claude
feat: add -y/--yes flag for non-interactive mode
c9d95ef 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@nilshamerlinck @claude
fix: always install default system packages in install-tools
04bb2a4 
Default OS packages (UBUNTU_PACKAGES etc.) were silently skipped when
system_packages was empty or absent in config. Two root causes fixed:
- _run_installers: removed the falsy-list guard around install_system_packages
- install_system_packages: removed early return that bypassed default packages

Also adds --install-default-system-packages/--no-install-default-system-packages
flag (default: true) to opt out of default package installation.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@nilshamerlinck nilshamerlinck changed the title Small fixes: npm migration, root check, config asset extraction Small fixes: npm migration, root check, config asset extraction, non-interactive mode, system packages fix Feb 25, 2026
@trisdoan trisdoan merged commit d109bbc into main Feb 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trisdoan trisdoan trisdoan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nilshamerlinck @trisdoan